-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[8.x] Add a phpunit comparator for models #38393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Testing\Comparators; | ||
|
|
||
| use Illuminate\Database\Eloquent\Model; | ||
| use SebastianBergmann\Comparator\Comparator; | ||
| use SebastianBergmann\Comparator\ComparisonFailure; | ||
|
|
||
| class ModelComparator extends Comparator | ||
| { | ||
| /** | ||
| * Checks if the two values are allowed to be compared with this comparator. | ||
| * | ||
| * @param mixed $expected | ||
| * @param mixed $actual | ||
| * @return bool | ||
| */ | ||
| public function accepts($expected, $actual): bool | ||
| { | ||
| return $expected instanceof Model && $actual instanceof Model; | ||
| } | ||
|
|
||
| /** | ||
| * Asserts that expected and actual are the same model. | ||
| * | ||
| * @param \Illuminate\Database\Eloquent\Model $expected | ||
| * @param \Illuminate\Database\Eloquent\Model $actual | ||
| * @param float $delta | ||
| * @param bool $canonicalize | ||
| * @param bool $ignoreCase | ||
| * @return void | ||
| */ | ||
| public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = false, $ignoreCase = false): void | ||
| { | ||
| if (! $expected->is($actual)) { | ||
| throw new ComparisonFailure( | ||
| $expected, | ||
| $actual, | ||
| "{$expected->getMorphClass()}::{$expected->getKey()}", | ||
| "{$actual->getMorphClass()}::{$actual->getKey()}", | ||
| ); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Testing; | ||
|
|
||
| use Illuminate\Support\ServiceProvider; | ||
| use Illuminate\Testing\Comparators\ModelComparator; | ||
| use SebastianBergmann\Comparator\Factory; | ||
|
|
||
| class TestingServiceProvider extends ServiceProvider | ||
| { | ||
| /** | ||
| * Register the service provider. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function register(): void | ||
| { | ||
| $comparatorFactory = Factory::getInstance(); | ||
| $comparatorFactory->register(new ModelComparator()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Tests\Testing\Comparators; | ||
|
|
||
| use Illuminate\Database\Eloquent\Model; | ||
| use Orchestra\Testbench\TestCase; | ||
|
|
||
| class ModelComparatorTest extends TestCase | ||
| { | ||
| public function testIsEqual() | ||
| { | ||
| $modelA = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
| $modelB = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
|
|
||
| $this->assertEquals($modelA, $modelB); | ||
| } | ||
|
|
||
| public function testIgnoresProperties() | ||
| { | ||
| $modelA = new TestModel([ | ||
| 'id' => 100, | ||
| 'text' => 'good', | ||
| ]); | ||
| $modelB = new TestModel([ | ||
| 'id' => 100, | ||
| 'text' => 'bad', | ||
| ]); | ||
|
|
||
| $this->assertEquals($modelA, $modelB); | ||
| } | ||
|
|
||
| public function testIsNotEqualIfDifferentKey() | ||
| { | ||
| $modelA = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
| $modelB = new TestModel([ | ||
| 'id' => 200, | ||
| ]); | ||
|
|
||
| $this->assertNotEquals($modelA, $modelB); | ||
| } | ||
|
|
||
| public function testIsNotEqualIfDifferentTable() | ||
| { | ||
| $modelA = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
| $modelA->setTable('table_a'); | ||
| $modelB = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
| $modelB->setTable('table_b'); | ||
|
|
||
| $this->assertNotEquals($modelA, $modelB); | ||
| } | ||
|
|
||
| public function testIsNotEqualIfDifferentConnection() | ||
| { | ||
| $modelA = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
| $modelA->setConnection('good'); | ||
| $modelB = new TestModel([ | ||
| 'id' => 100, | ||
| ]); | ||
| $modelA->setConnection('bad'); | ||
|
|
||
| $this->assertNotEquals($modelA, $modelB); | ||
| } | ||
| } | ||
|
|
||
| class TestModel extends Model | ||
| { | ||
| protected $guarded = []; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.