[9.x] Drop CommonMark v1 support #37953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinodell
approved these changes
Jul 8, 2021
Contributor
colinodell
left a comment
colinodell
left a comment
There was a problem hiding this comment.
Overall this looks perfect to me!
And I do have some uncommitted changes where both 1.x and 2.x work on Laravel 8.x without any nasty hacks if you'd like me to push that up :)
Member
Author
|
Thanks @colinodell! I'll close mine in favor of yours 👍 |
Member
Author
|
Just realized we can indeed rebase this one once yours has been merged. |
driesvints
changed the title
GrahamCampbell
requested changes
Jul 9, 2021
GrahamCampbell
approved these changes
Jul 10, 2021
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are straightforward but because of namespace changes to theEnvironmentclass we'll need to target v9. I think I can get CommonMark v2 working on 8.x but it'll require some nasty hacks. Feel free to let me know if you want to check into that.Drops CommonMark v1 support for Laravel v9