[8.x] Add missing port when replacing S3 temporary_url

[lakuapik]

When we change the temporary_url config for S3, laravel does not include the port.

Example config

// ...
'endpoint' => env('AWS_ENDPOINT', 'https://example.com:8000'),
'temporary_url' => env('AWS_TEMPORARY_URL', 'http://temp.example.com:8888'),
//...

Storage::temporaryUrl() will return the port 8000 instead of 8888.

This PR resolve that issue.

[BrandonSurowiec]

This is going to throw an error because $parsed['port'] won't exist in the array for a url without a port. (Like https://laravel.com)

[lakuapik]

Ah i see. It will give a warning <warning>PHP Notice: Undefined index: port in .... when the port is not specified.

My solution would be something like

return $uri->withScheme($parsed['scheme'])->withHost($parsed['host'])->withPort(@$parsed['port']);
// or
return $uri->withScheme($parsed['scheme'])->withHost($parsed['host'])->withPort($parsed['port'] ?? null);

Or what is the best solution in laravel way?

[BrandonSurowiec]

Would do the second:

return $uri->withScheme($parsed['scheme'])->withHost($parsed['host'])->withPort($parsed['port'] ?? null);

[lakuapik]

Okay.

Extra note that port can be nullable
https://github.com/php-fig/http-message/blob/efd67d1dc14a7ef4fc4e518e7dee91c271d524e4/src/UriInterface.php#L232-L240