Skip to content

[8.x] Throw exception when unable to create LockableFile #36674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2021
Merged

[8.x] Throw exception when unable to create LockableFile #36674

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e1274e
fix: exception when unable to create file
JVMartin Mar 19, 2021
2c7ca5b
lint
JVMartin Mar 19, 2021
518db8f
lint
JVMartin Mar 19, 2021
efa0228
Update LockableFile.php
taylorotwell Mar 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Illuminate/Filesystem/LockableFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Illuminate\Filesystem;

use Exception;
use Illuminate\Contracts\Filesystem\LockTimeoutException;

class LockableFile
Expand Down Expand Up @@ -65,6 +66,10 @@ protected function ensureDirectoryExists($path)
protected function createResource($path, $mode)
{
$this->handle = @fopen($path, $mode);

if (! $this->handle) {
throw new Exception('Unable to create lockable file: '.$path.'. Please ensure you have permission to create files in this location.');
}
}

/**
Expand Down