[8.x] Fix Mailer contract returns #36563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other factory contracts return an implementation of a contract. I think the original reason why this was a concrete is because the
MailManager'sresolvemethod always returns a concrete implementation ofIlluminate\Mail\Mailer. This is fine and while this technically means that theMailManagerwill always return an instance ofIlluminate\Mail\Mailerit's probably best to loosen the implementation on theFactorycontract to allow any implementation of aMailertype. TheMailcomponent should function perfectly fine with any mailer implementing this contract type.No breaking change because only DocBlocks were edited and existing code will continue to work as is.