[8.x] Add support to Eloquent Collection on Model::destroy() #36497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itxshakil
approved these changes
Mar 8, 2021
|
I guess, It should be merged as it is intended behavior. |
driesvints
changed the title
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently doing
SomeModel::destroy(SomeModel::all())will do nothing which to me was unexpected.This is due to the fact that
destroy()takes any Collection as a list of ids which is fine if we do :SomeModel::destroy(SomeModel::all()->pluck('whatever_primary_key'))or
SomeModel::destroy(SomeModel::all()->modelKeys())This PR will apply the second solution if an EloquentCollection is passed and keep the current behavior for BaseCollection.