[9.x] Fix BelongsToMany#updateOrCreate behaviour merge arguments for new models #35827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… merging arguments for newly created models
Member
|
@marcoboers it's best that you give a detailed explanation in your PR description at what this fixes. Otherwise this PR will probably get closed. |
Contributor
Author
|
@driesvints Thanks, I have updated the description. |
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with that the behavior of the
updateOrCreatemethod on BelongsToMany relationships is not merging the$attributesand$valuesarrays.This is different from the behaviour of the
updateOrCreatemethods onBuilder,HasOneOrManyandHasManyThroughclasses and from the documented behavior "If no such flight exists, a new flight will be created which has the attributes resulting from merging the first argument array with the second argument array" eloquent#upserts.Fixes #35798