[9.x] Remove illustrated layout from exceptions #35768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the illustrated layout is not used anymore inside the code. This feature was removed from Laravel 5.8. Also the laravel/laravel repo doesn't include the SVGs anymore. This breaks the layout, since the image/svgs cannot be found.
You might say the same for the
layout.blade.phpthat lives in the same directory. I decided to keep it there since it works out of the box, because of the CSS in the head and no reference to any external files.You might see this as a breaking change for people who upgrade from 5.8 to 8.x, so that's why I picked
master.