[8.x] Correct return type on View facade's first() #35750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I noticed I was committing from the wrong user credentials, causing my gpg-signature to be unverified. Sorry about that. |
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my IDE (VS Code) was making a fuss about
View::first()not returning aViewinstance, but aFactory(which it doesn't seem to return, sinceIlluminate\View\Factoryreturns aViewinstance (as noted in the factory docblock)I added the correct return type to the
Viewfacade and added a small test assertion to ensure this type is returned (which might be useless, but I added it for good measure).