Skip to content

Conversation

@finagin
Copy link
Contributor

@finagin finagin commented Dec 19, 2020

This change helpful to use the method in pipeline like this:

    public function initializeUsesUuid()
    {
        $this
            ->setKeyName('uuid')
            ->setKeyType('string')
            ->setIncrementing(false)
            ->mergeCasts([$this->getKeyName() => $this->getKeyType()])
            ->mergeGuarded([$this->getKeyName()]);
    }

@GrahamCampbell
Copy link
Collaborator

Please send to master, since this is a BC break (making a public method return something where it was void before in a non-final class).

@driesvints
Copy link
Member

@GrahamCampbell this isn't a breaking change

@finagin finagin changed the title Returns self after merge casts [8.x] Modify mergeCasts to return $this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants