[8.x] Make use of new PHP8 string functions #35439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We shouldn't be using these version checks in the framework. We can make use of these functions once PHP 8 is the minimum version. This doesn't really improve anything atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8, functions
str_starts_with(),str_ends_with()andstr_contains()were introduced. These are considered superior to userland implementations.This PR reimplements
Str::startsWith,Str::endsWith, andStr::containsusing the new built-in functions, while keeping backwards compatibility.Note: in laravel/helpers, function
str_contains()is already defined.To avoid infinite recursion for users using PHP 7 and the helpers package, in this PR forStr::containsPHP version is checked rather than the existence ofstr_contains().