[7.x] Fix BuildsQueries::tap() return type #32717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
But when and tap actually do have different return types. |
Contributor
Author
|
@taylorotwell But Which would mean that for the eloquent builder the return value is actually never a "normal" query builder unless the callback returns one, or am I missing something here? |
driesvints
added a commit
that referenced
this pull request
Aug 12, 2021
`when` already has `$this|mixed` so this should be reflected in `tap` on `BuildsQueries`. If you look at the logic inside `when` you'll see that this is the correct return type as it's either the return value of the given callback or `$this`. A previous attempt was made here: #32717 See a more thorough explanation here: #38343
taylorotwell
pushed a commit
that referenced
this pull request
Aug 12, 2021
`when` already has `$this|mixed` so this should be reflected in `tap` on `BuildsQueries`. If you look at the logic inside `when` you'll see that this is the correct return type as it's either the return value of the given callback or `$this`. A previous attempt was made here: #32717 See a more thorough explanation here: #38343
taylorotwell
pushed a commit
to illuminate/database
that referenced
this pull request
Aug 12, 2021
`when` already has `$this|mixed` so this should be reflected in `tap` on `BuildsQueries`. If you look at the logic inside `when` you'll see that this is the correct return type as it's either the return value of the given callback or `$this`. A previous attempt was made here: laravel/framework#32717 See a more thorough explanation here: laravel/framework#38343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the documented return type of
BuildsQueries::tap()to$this, which makes it soEloquent\Builder::tap()doesn't report it's return type asQuery\Builder. The reported return type will now be the exact same asBuildsQueries::when()which this method proxies.