-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[6.x] Added a new mutator cast type - time
#30931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
tests/Integration/Database/EloquentModelTimeCastingTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Tests\Integration\Database; | ||
|
|
||
| use Carbon\Carbon; | ||
| use Illuminate\Database\Eloquent\Model; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| class EloquentModelTimeCastingTest extends DatabaseTestCase | ||
| { | ||
| public function testTimesAreCastable() | ||
| { | ||
| $item = TestTimeModel::create([ | ||
| 'time_field' => '08:11:27', | ||
| ]); | ||
|
|
||
| $this->assertEquals(date_create('08:11:27'), $item->time_field); | ||
| $this->assertEquals(date_create('08:11:27'), $item->toArray()['time_field']); | ||
| $this->assertSame('08:11:27', $item->time_field->format('H:i:s')); | ||
| $this->assertSame('08:11', $item->time_field->format('H:i')); | ||
| $this->assertInstanceOf(Carbon::class, $item->time_field); | ||
| } | ||
|
|
||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
|
|
||
| Schema::create('test_model1', function (Blueprint $table) { | ||
| $table->increments('id'); | ||
| $table->time('time_field')->nullable(); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| class TestTimeModel extends Model | ||
| { | ||
| public $timestamps = false; | ||
|
|
||
| protected $table = 'test_model1'; | ||
|
|
||
| protected $guarded = ['id']; | ||
|
|
||
| protected $casts = [ | ||
| 'time_field' => 'time', | ||
| ]; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a microsecond reset because without it the time comparison would be wrong.
The TIME field type of the database does not store information about milliseconds, and when the
now ()functions are called in sequence, the values will be different.The
startOfSecond ()method leads them to a single value, as a result of which the comparison will be correct.The result of the verification showed here: #30931 (review)