[6.x] Changed Contract to Class #30088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Think we should thread a little careful here. This cascades a little higher up the chain to the queue method I see. |
- I have changed `\Illuminate\Contracts\Mail\Mailable` to `\Illuminate\Mail\Mailable`, since contract does not contains `cc` / `to` / `bcc` / `locale` methods, and in case if you call method only with contract, then we will get fatall error, since method is not present in the contract
TBlindaruk
force-pushed
the
change-contract-to-instance
branch
from
4119603 to
de16868
Compare
Contributor
Author
|
FIxed in all places, where this method is called. |
Member
|
I really think we shouldn't do this on a minor release. Seems to be breaking? |
Contributor
Author
|
hm, |
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Sep 24, 2019
- expand Mailable interface since `PendingMail::fill()` used some not existed method from the Mailable interface now. And it will caused an fatal error. Base PR: laravel#30088
Contributor
Author
|
#30089 changed to 7.0 |
taylorotwell
pushed a commit
that referenced
this pull request
Sep 25, 2019
- expand Mailable interface since `PendingMail::fill()` used some not existed method from the Mailable interface now. And it will caused an fatal error. Base PR: #30088
taylorotwell
pushed a commit
to illuminate/contracts
that referenced
this pull request
Sep 25, 2019
- expand Mailable interface since `PendingMail::fill()` used some not existed method from the Mailable interface now. And it will caused an fatal error. Base PR: laravel/framework#30088
taylorotwell
pushed a commit
to illuminate/mail
that referenced
this pull request
Sep 25, 2019
- expand Mailable interface since `PendingMail::fill()` used some not existed method from the Mailable interface now. And it will caused an fatal error. Base PR: laravel/framework#30088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Illuminate\Contracts\Mail\Mailableto\Illuminate\Mail\Mailable, since contract does not containscc/to/bcc/localemethods, and in case if you call method only with contract, then we will get fatall error, since method is not present in the contract