Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #28024 (targetting 5.8) for laravel 5.9. This is also a refactor for chunkById() and actually reduces the total lines of codes (except for tests) while adding a new feature.
New Feature:
eachById()is a more efficient alternative toeach(), just likechunkById()is tochunk(). The runtime complexity is not quadratic and it works fine for read-write scans as well.Changes:
chunkById()functions inQuery\BuilderandEloquent\Builderwas mostly duplicate, so I removed them and move their main parts toBuildsQueriestrait.chunkById()in the 2 classes are now moved todefaultKeyName()function.$columninQuery\Builder::chunkById()was 'id'. Now it is null.chunkById()is changed from "Chunk the results of a query by comparing numeric IDs." to "Chunk the results of a query by comparing IDs." because it handles non-numeric ids as well.