[5.8] eachById() #28015
Closed
[5.8] eachById() #28015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the PR not complete? |
|
I have not tested it. Besides I find later that chunkById have different default values for column in the 2 builder classes. So maybe there should be 2 functions implemented in 2 classes instead of one in a trait. |
|
@taylorotwell I force-pushed a commit. This now refactors chunkById() to prevent duplicate code both in chunkById() and eachById(). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eachById() is a more efficient alternative to each(), just like chunkById() is to chunk().
I really liked to call each() but not being skip-take based makes its runtime complexity quadratic.
I also wish chunk() and each() would do id based by default. Because, in my opinion, they reserve better names but they do worse.
This PR is not complete yet. Regard it as just an idea.