[5.8] Fix missing methods in queue job contract #26908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpelliott
changed the title
Contributor
|
Adding a method to an interface is a breaking change and as such this PR should target the master branch (Laravel 5.8). |
Contributor
Author
|
Thanks! I'll fix that |
jaredpelliott
force-pushed
the
add-missing-methods-to-queue-job-contract
branch
from
7cd942f to
c7cbd6d
Compare
jaredpelliott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A queue job that just implements the queue job contract causes 5 test failures in QueueWorkerTest. This is due to the contract missing the following 3 methods:
markAsFailed(),hasFailed(), andisReleased(). The first commit shows the problem and the next three add the missing methods, one at a time, causing the failing tests to progressively start passing again until they all do.