Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/Illuminate/Mail/PendingMail.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,16 @@
namespace Illuminate\Mail;

use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Contracts\Mail\Mailer as MailerContract;
use Illuminate\Contracts\Translation\HasLocalePreference;
use Illuminate\Contracts\Mail\Mailable as MailableContract;

class PendingMail
{
/**
* The mailer instance.
*
* @var \Illuminate\Mail\Mailer
* @var\Illuminate\Contracts\Mail\Mailer $mailer
*/
protected $mailer;

Expand Down Expand Up @@ -45,10 +47,10 @@ class PendingMail
/**
* Create a new mailable mailer instance.
*
* @param \Illuminate\Mail\Mailer $mailer
* @param \Illuminate\Contracts\Mail\Mailer $mailer
* @return void
*/
public function __construct(Mailer $mailer)
public function __construct(MailerContract $mailer)
{
$this->mailer = $mailer;
}
Expand Down Expand Up @@ -112,10 +114,11 @@ public function bcc($users)
/**
* Send a new mailable message instance.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable
*
* @return mixed
*/
public function send(Mailable $mailable)
public function send(MailableContract $mailable)
{
if ($mailable instanceof ShouldQueue) {
return $this->queue($mailable);
Expand All @@ -127,21 +130,21 @@ public function send(Mailable $mailable)
/**
* Send a mailable message immediately.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return mixed
*/
public function sendNow(Mailable $mailable)
public function sendNow(MailableContract $mailable)
{
return $this->mailer->send($this->fill($mailable));
}

/**
* Push the given mailable onto the queue.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return mixed
*/
public function queue(Mailable $mailable)
public function queue(MailableContract $mailable)
{
$mailable = $this->fill($mailable);

Expand All @@ -156,21 +159,21 @@ public function queue(Mailable $mailable)
* Deliver the queued message after the given delay.
*
* @param \DateTimeInterface|\DateInterval|int $delay
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return mixed
*/
public function later($delay, Mailable $mailable)
public function later($delay, MailableContract $mailable)
{
return $this->mailer->later($delay, $this->fill($mailable));
}

/**
* Populate the mailable with the addresses.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return \Illuminate\Mail\Mailable
*/
protected function fill(Mailable $mailable)
protected function fill(MailableContract $mailable)
{
return $mailable->to($this->to)
->cc($this->cc)
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Mail/SendQueuedMailable.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class SendQueuedMailable
/**
* The mailable message instance.
*
* @var \Illuminate\Mail\Mailable
* @var \Illuminate\Contracts\Mail\Mailable
*/
public $mailable;

Expand Down
8 changes: 4 additions & 4 deletions src/Illuminate/Support/Testing/Fakes/PendingMailFake.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Illuminate\Support\Testing\Fakes;

use Illuminate\Mail\Mailable;
use Illuminate\Mail\PendingMail;
use Illuminate\Contracts\Mail\Mailable;

class PendingMailFake extends PendingMail
{
Expand All @@ -21,7 +21,7 @@ public function __construct($mailer)
/**
* Send a new mailable message instance.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return mixed
*/
public function send(Mailable $mailable)
Expand All @@ -32,7 +32,7 @@ public function send(Mailable $mailable)
/**
* Send a mailable message immediately.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return mixed
*/
public function sendNow(Mailable $mailable)
Expand All @@ -43,7 +43,7 @@ public function sendNow(Mailable $mailable)
/**
* Push the given mailable onto the queue.
*
* @param \Illuminate\Mail\Mailable $mailable
* @param \Illuminate\Contracts\Mail\Mailable $mailable;
* @return mixed
*/
public function queue(Mailable $mailable)
Expand Down
3 changes: 2 additions & 1 deletion tests/Support/SupportTestingMailFakeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use PHPUnit\Framework\ExpectationFailedException;
use PHPUnit\Framework\Constraint\ExceptionMessage;
use Illuminate\Contracts\Translation\HasLocalePreference;
use Illuminate\Contracts\Mail\Mailable as MailableContract;

class SupportTestingMailFakeTest extends TestCase
{
Expand Down Expand Up @@ -141,7 +142,7 @@ public function testAssertNothingSent()
}
}

class MailableStub extends Mailable
class MailableStub extends Mailable implements MailableContract
{
public $framework = 'Laravel';

Expand Down