Skip to content

Conversation

@alexmanno
Copy link

As a title, I removed the useless else after returns.

(Without changing the logic)

@lagbox
Copy link
Contributor

lagbox commented Feb 1, 2018

These are the valueless changes that people have been complaining about.
I can't even remember where this shhtuff stands at the moment, been down this path before.

@alexmanno
Copy link
Author

@lagbox That's very welcoming.

@lagbox
Copy link
Contributor

lagbox commented Feb 1, 2018

@taylorotwell is this restyling of the framework actually happening or not as this type of stuff seems very inconsistent in what is merged and what isn't? Just trying to get an idea as I wasn't able to follow all the previous discussions on this exact thing.

@alexmanno alexmanno deleted the removed_useless_else branch February 1, 2018 21:13
@browner12
Copy link
Contributor

these PRs are not being accepted. we have had a discussion about improving our Contribution Guide to go over style stuff like this so we can bring more consistency to the framework. I had intended to take this on, but have been swamped lately.

@alexmanno
Copy link
Author

Many thanks for explanations @browner12 :)

@lagbox
Copy link
Contributor

lagbox commented Feb 1, 2018

@alexmanno Sorry, that was more of a note in general not quite for you, sorry about the tone.
Not valueless as in we don't value the contribution; valueless as in it doesn't actually add any value to the code, its just a term.

There has been an inconsistency with this particular issue over the last couple of months which is why I had thrown that out.

There was a reason (preference and explicit nature of them) for them being kept. Just wanted to know the final position on these.

@browner12 Thanks, I didn't know that was on you.

@browner12
Copy link
Contributor

I had brought it up and volunteered, but if someone wants to go for it, more power to them.

Like I said, I'm swamped at work now, so it's not going to get done soon if it's on me.

@lagbox
Copy link
Contributor

lagbox commented Feb 1, 2018

@browner12 maybe we can figure something out, im always on freenode[irc] (lagbox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants