-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Removed useless else after return #22991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These are the valueless changes that people have been complaining about. |
|
@lagbox That's very welcoming. |
|
@taylorotwell is this restyling of the framework actually happening or not as this type of stuff seems very inconsistent in what is merged and what isn't? Just trying to get an idea as I wasn't able to follow all the previous discussions on this exact thing. |
|
these PRs are not being accepted. we have had a discussion about improving our Contribution Guide to go over style stuff like this so we can bring more consistency to the framework. I had intended to take this on, but have been swamped lately. |
|
Many thanks for explanations @browner12 :) |
|
@alexmanno Sorry, that was more of a note in general not quite for you, sorry about the tone. There has been an inconsistency with this particular issue over the last couple of months which is why I had thrown that out. There was a reason (preference and explicit nature of them) for them being kept. Just wanted to know the final position on these. @browner12 Thanks, I didn't know that was on you. |
|
I had brought it up and volunteered, but if someone wants to go for it, more power to them. Like I said, I'm swamped at work now, so it's not going to get done soon if it's on me. |
|
@browner12 maybe we can figure something out, im always on freenode[irc] (lagbox) |
As a title, I removed the useless else after returns.
(Without changing the logic)