[5.4] else unnecessary in this snippet #19475
Conversation
|
@geekcom Tests is failing now.. |
| $this->items[$key] = $value; | ||
| } | ||
|
|
||
| $this->items[$key] = $value; |
There was a problem hiding this comment.
this is always going to be executed now
There was a problem hiding this comment.
@geekcom: you could've only done that shortening if you were breaking the path of execution (using guard clauses for instance). I wouldn't recommend that though, since it alters type signature in this case.
There was a problem hiding this comment.
ok, let's see what happens with this PR.
There was a problem hiding this comment.
you broke the functionality of at least 1 method for no reason at all ... what do you think is going to happen? :)
There was a problem hiding this comment.
humm, that's make sense, so sorry
|
In short, there is nothing 'unnecessary or redundant' about this else. |
geekcom
changed the title
| usort($items, function () { | ||
| return rand(-1, 1); | ||
| }); | ||
|
|
There was a problem hiding this comment.
again ... this is now always going to be executed
3 participants
elsecondition within that method of yours is either unnecessary or redundant.