Skip to content

Conversation

@mrliptontea
Copy link

Previous PR: #18391

This time I decided not to introduce any new methods, just make array access behave exactly as magic methods do.

Note: I still think this is a bug fix, and according to the documentation, it should go into latest or LTS.

@mrliptontea
Copy link
Author

Potential refactor, for consistency: Illuminate\Container\Container is re-using offset methods implicitly.
Either I change it in my PR so Model and Fluent do the same, or change Container to call offset methods.

@taylorotwell taylorotwell merged commit 26475a4 into laravel:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants