`Illuminate\Queue\Jobs\DatabaseJob::getJobId` does not respect its interface

[petrknap]

Laravel Version

11.44.1

PHP Version

8.3.17

Database Driver & Version

No response

Description

Method Illuminate\Queue\Jobs\Job::getJobId is annotated by @return string, but in fact in Illuminate\Queue\Jobs\DatabaseJob it returns $this->job->id which is annotate like stdClass and is mixed.

Steps To Reproduce

1. Set-up DB queue with integer primary key
2. Try to process a job
3. The method getJobId returns integer

[crynobone]

Hey there, thanks for reporting this issue.

If you notice improper DocBlock, PHPStan, or IDE warnings while using Laravel, do not create a GitHub issue. Instead, please submit a pull request to fix the problem. Also see our contribution guide.

Thanks!

[petrknap]

We noticed fatal error / application crash as string is not an integer, there is declare(strict_types=1); with us for many years.

declare(strict_types=1);

function foo(string $bar): void {}

foo($dbJob->getJobId());  # TypeError: foo(): Argument #1 ($bar) must be of type string, int given

I'm sorry, I can't fix it. I don't know if the job id must be string (the implementation is wrong) or if job id should be mixed (the interface is wrong).

[petrknap]

So... do you have an official opinion on whether the implementation or the interface (abstract) is correct?

I'm expecting positive answer, even such bad designed piece off scrap like Laravel must be deterministic.