Error with new aws/aws-sdk-php

[labomatik]

• Laravel Version: 9.40.1
• PHP Version: 8.1.5
• Database Driver & Version: Mysql 8.0.28

Description:

We are currently using a filesystem that is hosted at DigitalOcean (space), we are using the AWS adapter requiring a few packages, one of the packages: aws/aws-sdk-php

By upgrading from 3.242.1 to 3.243.0 we suddenly got issues in our system (a nasty Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '256' frames)

We tested by pinning in our composer.json
"aws/aws-sdk-php": "3.242.1", -> OK
"aws/aws-sdk-php": "3.243.0", -> NOT OK

After investigation, we identified this bug reported on that repo:
aws/aws-sdk-php#2563

We tried to apply the patch proposed on src/Illuminate/Filesystem/FilesystemManager.php (before $client = new S3Client($s3Config)):
$s3Config['endpoint_provider'] = PartitionEndpointProvider::defaultProvider();
and that fixes the issue...

Seems like it's linked to a file that starts with / (example : /private/image.gif )

[driesvints]

Seems like they fixed it in 3.244.1 so please upgrade to that version.

[labomatik]

We updated to 3.245.0 but the issue was still present.

[driesvints]

Please open an issue with the AWS PHP SDK as this is a breaking change with them.

[georgeboot]

Possibly related to aws/aws-sdk-php#2567

[georgeboot]

Seems like Laravel injects token option to some sdk clients as a root option, instead of it being inside the credentials key. That isnt ignored anymore since token is now a valid option.

[labomatik]

I'm not sure it's related because by patching src/Illuminate/Filesystem/FilesystemManager.php and adding
$s3Config['endpoint_provider'] = PartitionEndpointProvider::defaultProvider(); it's solving the issue. But there is something wrong with the combination laravel and aws-sdk-php 3.245.0 (after 3.242.1 at least)

[driesvints]

@labomatik can you try the PR by @georgeboot to see if that resolves your issue? #44979

[labomatik]

That's not fixing the issue with that PR

[driesvints]

Please open an issue on the AWS PHP SDK then as this does not seem like a bug within Laravel.

[labomatik]

Yes i'll do ;-)

[stobrien89]

Hi @driesvints, @georgeboot, @labomatik,

Apologies for all of the issues.

@labomatik,

Glad you were able to patch this for now, but I'd like to get this addressed if this is an issue with our implementation. Could you open an issue against our repository with more information about the operations/config you're using for this library?

Edit: Just saw your comment on aws/aws-sdk-php#2563

Thanks!