Route caching returns wrong route if route name is equal to the application prefix

[ndossche]

• Laravel Version: 9.14.0
• PHP Version: 8.1.6
• Database Driver & Version: MariaDB 10.8.3

Description:

While upgrading a Laravel application from 6.x to 9.x, I encountered the following regression.

Context: We have a Laravel application installed on the path http://server/pathname/.
We have a route linked to a controller in our application with the same name as the prefix path of the application: "/pathname" (i.e. accessible via http://server/pathname/pathname).

The bug: The application works fine in 9.x unless I enable route caching. When I surf to the homepage (http://server/pathname/) with route caching enabled, Laravel believes I'm actually surfing to http://server/pathname/pathname. This did work perfectly fine in Laravel 6.x with route caching enabled.

I tracked it down to the function match in the class CompiledRouteCollection. The wrong route is returned from the matchRequest call. I manually worked around this issue by modifying requestWithoutTrailingSlash to also remove the prefix "/pathname".

Steps To Reproduce:

• Create a new Laravel 9.x app under a subdirectory "/pathname" (perhaps a directory is not strictly necessary, I believe any kind of prefix will do)
• Create a route linked to a controller with path "/pathname"
• Execute route:cache
• The application returns the page for "/pathname/pathname" when surfing to "/pathname"

[rodrigopedra]

Serving a Laravel application from a subdirectory is not officially supported at this time:

https://laravel.com/docs/9.x#directory-configuration

There were some issues before regarding this subject and all were closed due to this feature being unsupported:

• Trailing Slash Bug For Cached Index Route #32082 (comment)
• Discrepancy between routes and cached routes with APP_URL having a subfolder #32236 (comment)
• Route caching results in 405 Method Not Allowed for root path #32832 (comment)
• app('router')->getRoutes()->match() - Dosen't work correctly when running on subdirectory #34362 (comment)
• The GET method is not supported for this route. Supported methods: HEAD. #34977 (comment)
• Wrong $request->url() while running on a sub-path using a Reverse Proxy #35241
• Password reset e-mail address is duplicating information with custom APP_URL #37462 (comment)

note: linked comments are from Laravel core members

Although this PR merged on 9.x might help you out, if you are using nginx: #40014

[ndossche]

Alright thanks for the insight.
The nginx approach will do.

[taai]

Serving a Laravel application from a subdirectory is not officially unsupported at this time:

I believe you meant "is not officially supported". 😉

[rodrigopedra]

Thanks @taai 😀