[6.x] PHP 8 Support #831
Merged
[6.x] PHP 8 Support #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driesvints is this also being tagged on Tuesday? |
Member
Author
|
This shouldn't have been merged as this wasn't ready yet (see the build). It'll be tagged as soon as php-webdriver/webdriver has been patched (which I'm going to look into now). |
Member
Author
|
(I should have marked this PR as draft) |
|
I see. the test matrix is off. |
2 tasks
driesvints
added a commit
that referenced
this pull request
Nov 6, 2020
This reverts commit 0736268.
driesvints
added a commit
that referenced
this pull request
Nov 6, 2020
This reverts commit c005c11.
Merged
Member
Author
|
Reverted this one for now and resubmitted a draft PR. |
driesvints
added a commit
that referenced
this pull request
Nov 19, 2020
This reverts commit c005c11.
taylorotwell
pushed a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.