Remove outdated (?) warning about constraining eager loaded relationships #9200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that
"The limit and take query builder methods may not be used when constraining eager loads."
However, in multiple tests, these methods did work.
Is the doc too ambiguous and I misunderstood it? Or is this warning outdated and needs to be removed?
I understood it to mean that the relationship that's being eager loaded can't be limited, i.e., all related rows will be returned, no matter what. However, when I use limit, it returns no more than the limit specified.
I can't open an issue in this repo, so I made a PR instead, removing this warning.