fix: related relationship responses top level links self link should be the relations related link
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be the relations `related` link
Contributor
|
Thanks for this, the PR helped. I did make some minor changes to ensure that any custom set links are merged after we've done the flipping of If you're interested, the changes I made are in ad1d591 |
Contributor
Author
Makes sense to me, glad it helped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec states top level links objects may contain a
selflink asthe link that generated the current response document.Currently relationship
relatedendpoints will return aselflink that points to therelationshipendpoint.This PR corrects this so that the self link is replaced with the value of the
relatedlink and the redundantrelatedlink removed on related responses.This is the cleanest way I could see to implement it but happy to rework it if needed.