Feature: Add Document Retrieval with Metadata Filtering #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cedrickrusche Thank you for opening this PR! I've left a couple of comments |
|
@dishaprakash Thank you for commenting but I can not see the comments |
| results = result_map.fetchall() | ||
| return bool(len(results) == 1) | ||
|
|
||
| async def aget( |
There was a problem hiding this comment.
Please add a synchronous function get which returns an error, similar to these.
| k: Optional[int] = None, | ||
| **kwargs: Any, | ||
| ) -> list[Document]: | ||
|
|
There was a problem hiding this comment.
Please add a docstring to this function
|
@cedrickrusche sorry about the confusion, is it visible now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the methods get and aget like in ChromaDB to retrieve data by metadata.
🔧 Changes
agetmethod to asynchronously retrieve documents based on optional filters and parameters.getmethod for synchronous document retrieval, leveraging the asynchronousagetmethod.__query_collection_with_filtermethod to support filtering conditions in the SQL WHERE clause without similarity function📈 Impact
These changes let us retrieve the current content to get insights about the data in the database e.g. to find outdated content.