Skip to content

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Oct 8, 2025

Fixes #682

@3coins 3coins changed the title Fix for cohere v4 embeddings fix: Fix for cohere v4 embeddings Oct 8, 2025
@3coins
Copy link
Collaborator Author

3coins commented Oct 8, 2025

Ran the integration tests locally to cover both v3 and v4.

tests/integration_tests/embeddings/test_bedrock_embeddings.py ......s............                                                                                       [100%]

============================================================================= slowest 5 durations =============================================================================
2.71s call     tests/integration_tests/embeddings/test_bedrock_embeddings.py::test_bedrock_cohere_embedding_large_document_set[cohere_embeddings1]
1.79s setup    tests/integration_tests/embeddings/test_bedrock_embeddings.py::test_bedrock_embedding_documents
1.65s call     tests/integration_tests/embeddings/test_bedrock_embeddings.py::test_bedrock_cohere_embedding_large_document_set[cohere_embeddings0]
0.75s call     tests/integration_tests/embeddings/test_bedrock_embeddings.py::test_bedrock_embedding_documents_multiple
0.61s call     tests/integration_tests/embeddings/test_bedrock_embeddings.py::test_bedrock_cohere_embedding_documents_multiple[cohere_embeddings1]
======================================================================= 18 passed, 1 skipped in 13.21s ========================================================================

@3coins
Copy link
Collaborator Author

3coins commented Oct 9, 2025

@notfoundry
Do you want to try these changes, and let me know if there is any feedback before we merge?

Copy link
Collaborator

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3coins , LGTM 👍

@7AM7
Copy link

7AM7 commented Oct 13, 2025

@3coins when you can release this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cohere v4 embeddings still broken after #681

3 participants