Fix emission of outer name in InnerClass entries #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3d66b0d contains the following change: - val outerNameModule = if (isTopLevelModuleClass(innerClassSym.rawowner)) outerName.dropModule + val outerNameModule = if (innerClassSym.isTopLevelModuleClass) outerName.dropModule It looks like the `.rawowner` got accidentally dropped. The result is that for the given code: object Outer { class Inner } The ClassEntry for Inner has outer name "Outer$" instead of "Outer", this prevents referencing "Outer.Inner" from Java code.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 10, 2017
The backend uses `rawname` to define the "inner name" of an InnerClass entry in a classfile, this should be the simple name of the class before any mangling takes place but before this commit, we put the mangled name after flatten there. Fixing this allows Java code to reference dotty inner classes, except if they're defined in objects which is still broken until lampepfl/scala#4 is merged and a new backend is published.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 10, 2017
The backend uses `rawname` to define the "inner name" of an InnerClass entry in a classfile, this should be the simple name of the class before any mangling takes place but before this commit, we put the mangled name after flatten there. Fixing this allows Java code to reference dotty inner classes, except if they're defined in objects which is still broken until lampepfl/scala#4 is merged and a new backend is published.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2017
It does not compile with dotty because of scala#1894 and lampepfl/scala#4
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2017
It does not compile with dotty because of scala#1894 and lampepfl/scala#4
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2017
It does not compile with dotty because of scala#1894 and lampepfl/scala#4
|
LGTM |
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2017
The backend uses `rawname` to define the "inner name" of an InnerClass entry in a classfile, this should be the simple name of the class before any mangling takes place. Fixing this allows Java code to reference dotty inner classes, except if they're defined in objects which is still broken until lampepfl/scala#4 is merged and a new backend is published.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 27, 2017
The upgraded backend contains a single new PR: lampepfl/scala#4 which fixes Java interop with Dotty-emitted inner classes in objects.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 27, 2017
The upgraded backend contains a single new PR: lampepfl/scala#4 which fixes Java interop with Dotty-emitted inner classes in objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3d66b0d contains the following change:
It looks like the
.rawownergot accidentally dropped. The result isthat for the given code:
The ClassEntry for Inner has outer name "Outer$" instead of "Outer",
this prevents referencing "Outer.Inner" from Java code.