Port #4963 #23
Merged
Port #4963 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Passed the tests on scala/scala3#3115 |
Author
|
Needs review |
nicolasstucki
requested review from
allanrenucci
and removed request for
smarter
smarter
approved these changes
Sep 14, 2017
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
For each ported commit, it would be nice to edit the message to give the hash of the corresponding original commit
|
|
||
| object BCodeHelpers { | ||
|
|
||
| class InvokeStyle(val style: Int) extends AnyVal { |
Member
There was a problem hiding this comment.
If you port this, I think it would also make sense to port the rest of 7a12e81 if it's not too hard.
nicolasstucki
force-pushed
the
port-#4963-2
branch
from
2e272b1 to
2e3214c
Compare
Port of 7a12e81
nicolasstucki
force-pushed
the
port-#4963-2
branch
from
2e3214c to
136c562
Compare
GenBCode used to generate more bytecode for branching instructions than
GenASM. A simple method
def f(x: Int, b: Boolean) = if (b) 1 else 2
would generate
ILOAD 2
IFNE L1
GOTO L2
L1
ICONST_1
GOTO L3
L2
ICONST_2
L3
IRETURN
If the conditional branch is negated (IFEQ) the GOTO is unnecessary.
While -Yopt:l:method would clean this up, it's also not too hard to
generate the leaner bytecode in the first place.
Port of f70c77e
When loading a value of type scala.runtime.Null$ we need to add POP; ACONST_NULL, see comment in BCodeBodyBuilder.adapt. This is however not necessary if the null value is a simple ACONST_NULL. This patch eliminates that redundancy. Port of 9b334b2
nicolasstucki
force-pushed
the
port-#4963-2
branch
from
136c562 to
040ccf2
Compare
allanrenucci
approved these changes
Sep 15, 2017
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
LGTM provided that the tests pass
Author
|
Passed the tests on scala/scala3#3115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.