Skip to content

Increased code robustness and consistency within the framework #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suwakei
Copy link

@suwakei suwakei commented Jun 23, 2025

Proposal

1. Error handling when reading request body:

Currently, errors in io.ReadAll(c.Request().Body) are ignored. If the read fails, subsequent handlers may receive an incomplete body, causing unexpected behavior. I believe that the robustness of the middleware can be improved by interrupting processing when an error occurs and returning an error.

import (
	"bufio"
	"bytes"
+++	"fmt"
	"errors"
	"io"
	"net"
// omission of sentence
			// Request
			reqBody := []byte{}
			if c.Request().Body != nil { // Read
---				reqBody, _ = io.ReadAll(c.Request().Body)
+++				var errRead error
+++				reqBody, errRead = io.ReadAll(c.Request().Body)
+++				if errRead != nil {
+++					return errRead
+++				}
			}
			c.Request().Body = io.NopCloser(bytes.NewBuffer(reqBody)) // Reset

2. Improvement of Flush panic messages:

Improve the messages when a panic occurs in the Flush method to be more detailed and consistent with the rest of the Echo framework (e.g., response.go). We believe this will make it clearer which ResponseWriters do not support the Flusher interface and make debugging easier.

import (
	"bufio"
	"bytes"
+++	"fmt"
	"errors"
	"io"
	"net"
// omission of sentence
func (w *bodyDumpResponseWriter) Flush() {
	err := http.NewResponseController(w.ResponseWriter).Flush()
	if err != nil && errors.Is(err, http.ErrNotSupported) {
		panic(errors.New("response writer flushing is not supported"))
		panic(fmt.Errorf("echo: response writer %T does not support flushing (http.Flusher interface)", w.ResponseWriter))
	}
}

3. Modification of tests to accommodate the above changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant