Skip to content

feat(taskrunner): transfer arraybuffer in runloaderresult #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019
Merged

feat(taskrunner): transfer arraybuffer in runloaderresult #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/adapters/workerEntryPoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as loaderRunner from 'loader-runner';
import { Subject, from, of } from 'rxjs';
import { catchError, map, mergeMap } from 'rxjs/operators';
import { enableLoggerGlobal, getLogger } from '../utils/logger';
import { expose, proxy } from 'comlink';
import { expose, proxy, transfer } from 'comlink';
import { parentPort, workerData } from 'worker_threads';

import { WorkerTaskData } from './WorkerTaskData';
Expand Down Expand Up @@ -53,6 +53,17 @@ const buildLoaderOption = (

type TaskQueueContext = Omit<WorkerTaskData, 'id'> & { task: { id: number; logLevel: 'verbose' | 'info' } };

// [todo]: support nested objects
const collectBuffer = (result: loaderRunner.RunLoaderResult) => {
const ret = Object.values(result).reduce((acc, value) => {
if (ArrayBuffer.isView(value)) {
acc.push(value.buffer);
}
return acc;
}, []);
return ret;
};

/**
* Interface to allow running specified task in worker threads,
* exposed via comlink proxy.
Expand Down Expand Up @@ -98,7 +109,12 @@ const taskRunner = (() => {
if (err) {
onError(err);
} else {
onComplete(result);
const buffer = collectBuffer(result);
if (buffer.length > 0) {
onComplete(transfer(result, buffer));
} else {
onComplete(result);
}
}
},
(e) => {
Expand Down