Allow compiling on GCC < 5 / CentOS 6 (see #138) #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per kvspb#138 (comment) the issue is that: * nginx compiles with `-Werror` (treating warnings as errors) * CentOS 6 has OpenSSL 1.0.1e and so the LDAP module has a warning on compile * CentOS 6 has GCC 4.4. GCC treats `#pragma GCC diagnostic warning "-Wcpp"` as itself an error and thus skips the statement, leading the the `#warning` still being an error. This adds version-checking to the warning options and the warning itself. This means that no warning is issued at compile time on this type of platform, but warnings are still emitted when starting Nginx without certificate verification, so it isn't as though the issue has been hidden.
|
As an alternative to merging this, wait until November so CentOS 6 goes EOL 😄 |
|
Wow!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #138 (and specifically #138 (comment)) the issue is that:
-Werror(treating warnings as errors)#pragma GCC diagnostic warning "-Wcpp"as an error itself and thus skips the statement, leading to the#warningstill being an error.This adds version-checking to the warning options and the warning
itself. This means that no warning is issued at compile time on this
type of platform, but warnings are still emitted when starting Nginx
without certificate verification, so the issue is still visible in a notable way.
Other solutions to making this module compile on CentOS 6 / GCC 4.4 are welcomed, but this seems like the lightest touch.