fix: subscription error handling during server shutdown #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
DEVEX-256-Java-Client-Fix-subscription-reconnection-during-server-shutdown
branch
from
0555759 to
24bee81
Compare
YoEight
approved these changes
Mar 20, 2025
w1am
deleted the
DEVEX-256-Java-Client-Fix-subscription-reconnection-during-server-shutdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #310
When the server shuts down while a subscription is active, the client wasn't properly detecting this condition or attempting to reconnect. The error propagation path was broken, preventing the
CreateChannelmessages from being queued for reconnection attempts. Also, if errors occurred before subscription confirmation, the CompletableFuture wasn't being completed exceptionally, which could lead to hanging client code.