Extract tracing metadata from Event not OriginalEvent #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
DEVEX-77-Java-Client-Don-t-create-span-for-events-with-non-json-metadata
branch
from
b6cd535 to
ac15c5c
Compare
w1am
changed the title
w1am
force-pushed
the
DEVEX-77-Java-Client-Don-t-create-span-for-events-with-non-json-metadata
branch
from
ac15c5c to
8af0a89
Compare
YoEight
approved these changes
Sep 1, 2024
YoEight
deleted the
DEVEX-77-Java-Client-Don-t-create-span-for-events-with-non-json-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Extract tracing metadata from Event
We were previously extracting trace context from the OriginalEvent. This means we will not be able to extract the trace information when consuming events from a category stream. This PR extracts the trace information from the Event itself. This applies to both regular and persistent subscriptions.
Also improved test
testTracingContextInjectionIsIgnoredAsExpectedWhenUserMetadataIsNonNullAndNotAJsonObjectto ensure no span is created in subscription for events with non-json metadata.