Skip to content

Conversation

@yashsingh74
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2025
@yashsingh74
Copy link
Member Author

cc: @ahrtr @joshjms @hakman @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the 3.6.6 images in gcr.io/k8s-staging-etcd/etcd yet.

@joshjms @hakman did you manually push the images previously? Does it require any permission?

"sha256:0f87957e19b97d01b2c70813ee5c4949f8674deac4a65f7167c4cd85f7f2941e": ["v3.6.5-arm64"]
"sha256:2055881a1107b7e1bf7002b48544aed8b7da517d4d8e138c7b3b67abbf73a81d": ["v3.6.5-ppc64le"]
"sha256:dfecf781891d331534930c82444272582feb768fb07b51a0cc1e51d7ebbbc170": ["v3.6.5-s390x"]
"sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890": ["v3.6.6"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add 3.6.6-0 as well. cc @joshjms @hakman

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the digest from our gcr.io registry to promote that image to registry.k8s.io immediately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➜  ~ crane digest gcr.io/etcd-development/etcd:v3.6.6         
sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890

lgtm 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that the digests do not change.

But gcr.io/etcd-development/etcd and gcr.io/k8s-staging-etcd/etcd are two different registries. I only see the etcd 3.6.6 images in the former, not the latter.

Isn't this a problem?

Copy link
Member

@joshjms joshjms Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh nope it's not a problem, gcr.io/etcd-development is already added as a source registry here 22cf2aa so we don't need to push it to k8s-staging-etcd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thx for the clarification.

@ahrtr
Copy link
Member

ahrtr commented Nov 19, 2025

Reference: #8344

"sha256:0f87957e19b97d01b2c70813ee5c4949f8674deac4a65f7167c4cd85f7f2941e": ["v3.6.5-arm64"]
"sha256:2055881a1107b7e1bf7002b48544aed8b7da517d4d8e138c7b3b67abbf73a81d": ["v3.6.5-ppc64le"]
"sha256:dfecf781891d331534930c82444272582feb768fb07b51a0cc1e51d7ebbbc170": ["v3.6.5-s390x"]
"sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890": ["v3.6.6"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➜  ~ crane digest gcr.io/etcd-development/etcd:v3.6.6         
sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890

lgtm 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2025
@joshjms
Copy link
Member

joshjms commented Nov 19, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@joshjms
Copy link
Member

joshjms commented Nov 19, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@ahrtr
Copy link
Member

ahrtr commented Nov 19, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, joshjms, yashsingh74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 81062b7 into kubernetes:main Nov 19, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 19, 2025
@bzsuni
Copy link
Contributor

bzsuni commented Nov 24, 2025

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/135271/pull-kubernetes-e2e-kind/1991394355570544640

Failed to pull registry.k8s.io/etcd:3.6.6-0 with error: command "docker exec --privileged kind-build-1763620611-173758150 ctr --namespace=k8s.io content fetch --platform=linux/amd64 registry.k8s.io/etcd:3.6.6-0" failed with error: exit status 1
time="2025-11-20T06:36:54Z" level=info msg="fetch failed after status: 404 Not Found" host=registry.k8s.io
ctr: failed to resolve reference "registry.k8s.io/etcd:3.6.6-0": registry.k8s.io/etcd:3.6.6-0: not found
Retrying registry.k8s.io/etcd:3.6.6-0 pull after 1s ...
Image build Failed! Failed to pull Images: command "docker exec --privileged kind-build-1763620611-173758150 ctr --namespace=k8s.io content fetch --platform=linux/amd64 registry.k8s.io/etcd:3.6.6-0" failed with error: exit status 1
ERROR: error building node image: command "docker exec --privileged kind-build-1763620611-173758150 ctr --namespace=k8s.io content fetch --platform=linux/amd64 registry.k8s.io/etcd:3.6.6-0" failed with error: exit status 1

Image registry.k8s.io/etcd:3.6.6-0 not found, what should I do to solve this? @joshjms

@ahrtr
Copy link
Member

ahrtr commented Nov 24, 2025

Image registry.k8s.io/etcd:3.6.6-0 not found, what should I do to solve this? @joshjms

It's because the tag 3.6.6-0 wasn't added in #8769 (comment).

I think we can use v3.6.6 for Kubernetes workflow, but it might be a problem for Kubeadm. cc @joshjms @hakman @neolit123

@neolit123
Copy link
Member

I think we can use v3.6.6 for Kubernetes workflow, but it might be a problem for Kubeadm. cc @joshjms @hakman @neolit123

as long as the image exists in the registry and the kubeadm constants file is set to use it, it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants