-
Notifications
You must be signed in to change notification settings - Fork 946
Add etcd 3.6.6 publish images #8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yashsingh74 <[email protected]>
ahrtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "sha256:0f87957e19b97d01b2c70813ee5c4949f8674deac4a65f7167c4cd85f7f2941e": ["v3.6.5-arm64"] | ||
| "sha256:2055881a1107b7e1bf7002b48544aed8b7da517d4d8e138c7b3b67abbf73a81d": ["v3.6.5-ppc64le"] | ||
| "sha256:dfecf781891d331534930c82444272582feb768fb07b51a0cc1e51d7ebbbc170": ["v3.6.5-s390x"] | ||
| "sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890": ["v3.6.6"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the digest from our gcr.io registry to promote that image to registry.k8s.io immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➜ ~ crane digest gcr.io/etcd-development/etcd:v3.6.6
sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890
lgtm 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that the digests do not change.
But gcr.io/etcd-development/etcd and gcr.io/k8s-staging-etcd/etcd are two different registries. I only see the etcd 3.6.6 images in the former, not the latter.
Isn't this a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh nope it's not a problem, gcr.io/etcd-development is already added as a source registry here 22cf2aa so we don't need to push it to k8s-staging-etcd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thx for the clarification.
|
Reference: #8344 |
| "sha256:0f87957e19b97d01b2c70813ee5c4949f8674deac4a65f7167c4cd85f7f2941e": ["v3.6.5-arm64"] | ||
| "sha256:2055881a1107b7e1bf7002b48544aed8b7da517d4d8e138c7b3b67abbf73a81d": ["v3.6.5-ppc64le"] | ||
| "sha256:dfecf781891d331534930c82444272582feb768fb07b51a0cc1e51d7ebbbc170": ["v3.6.5-s390x"] | ||
| "sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890": ["v3.6.6"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➜ ~ crane digest gcr.io/etcd-development/etcd:v3.6.6
sha256:60a30b5d81b2217555e2cfb9537f655b7ba97220b99c39ee2e162a7127225890
lgtm 😄
|
/hold |
|
/unhold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, joshjms, yashsingh74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Failed to pull registry.k8s.io/etcd:3.6.6-0 with error: command "docker exec --privileged kind-build-1763620611-173758150 ctr --namespace=k8s.io content fetch --platform=linux/amd64 registry.k8s.io/etcd:3.6.6-0" failed with error: exit status 1
time="2025-11-20T06:36:54Z" level=info msg="fetch failed after status: 404 Not Found" host=registry.k8s.io
ctr: failed to resolve reference "registry.k8s.io/etcd:3.6.6-0": registry.k8s.io/etcd:3.6.6-0: not found
Retrying registry.k8s.io/etcd:3.6.6-0 pull after 1s ...
Image build Failed! Failed to pull Images: command "docker exec --privileged kind-build-1763620611-173758150 ctr --namespace=k8s.io content fetch --platform=linux/amd64 registry.k8s.io/etcd:3.6.6-0" failed with error: exit status 1
ERROR: error building node image: command "docker exec --privileged kind-build-1763620611-173758150 ctr --namespace=k8s.io content fetch --platform=linux/amd64 registry.k8s.io/etcd:3.6.6-0" failed with error: exit status 1Image registry.k8s.io/etcd:3.6.6-0 not found, what should I do to solve this? @joshjms |
It's because the tag 3.6.6-0 wasn't added in #8769 (comment). I think we can use v3.6.6 for Kubernetes workflow, but it might be a problem for Kubeadm. cc @joshjms @hakman @neolit123 |
as long as the image exists in the registry and the kubeadm constants file is set to use it, it would work. |
Added the etcd 3.6.6 sha for publish
Ref: https://console.cloud.google.com/artifacts/docker/etcd-development/us/gcr.io/etcd