Skip to content

Conversation

@rst0git
Copy link
Member

@rst0git rst0git commented Nov 18, 2025

@rst0git
Copy link
Member Author

rst0git commented Nov 18, 2025

@rst0git rst0git force-pushed the wg-checkpoint-restore branch from d5731fa to 4ac1f4a Compare November 18, 2025 02:09
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Nov 18, 2025
@rst0git rst0git added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Nov 18, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 18, 2025
@rst0git rst0git force-pushed the wg-checkpoint-restore branch from 4ac1f4a to 238e16e Compare November 18, 2025 02:19
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 18, 2025
@haircommander
Copy link

do you have examples of having multiple emails per person for one of these lists? it doesn't seem typical to me and I'm not sure if there's some policy around it

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2025
@rst0git rst0git force-pushed the wg-checkpoint-restore branch from 238e16e to 538d1df Compare November 18, 2025 14:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2025
@rst0git
Copy link
Member Author

rst0git commented Nov 18, 2025

@haircommander I've updated the patch to use one email per person.

@rst0git rst0git force-pushed the wg-checkpoint-restore branch from 538d1df to a1dc7f0 Compare November 18, 2025 14:53
@viktoriaas
Copy link

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2025
@adrianreber
Copy link
Member

/approve

@BenTheElder
Copy link
Member

do you have examples of having multiple emails per person for one of these lists? it doesn't seem typical to me and I'm not sure if there's some policy around it

Yes this is fine, for example multiple steering members (including myself) have a personal email included in the steering lists for reasons like employer google docs restrictions

I'm not aware of any policy prohibiting it.

At some point we might want to drive leads type lists from the central source of truth in kubernetes/community sigs.yaml, but I don't know anyone planning to work on this and if/when that happens there will be other cases like this.

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@BenTheElder
Copy link
Member

/assign @hakman @GenPage

@hakman
Copy link
Member

hakman commented Nov 18, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, BenTheElder, hakman, rst0git, viktoriaas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@ameukam
Copy link
Member

ameukam commented Nov 19, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit f6de5a2 into kubernetes:main Nov 19, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants