Skip to content

KEP 5075: update API description, add alternatives, update test plan #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP 5075: update API description, add alternatives, update test plan #5449

wants to merge 1 commit into from
+453 −469

Conversation

sunya-ch
Copy link
Contributor

@sunya-ch sunya-ch commented Jul 11, 2025 •
edited
Loading

  • One-line PR description: Update API descriptions, add alternatives and test plan those have been discussed and suggested after the previous PR merged.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunya-ch
Once this PR has been reviewed and has the lgtm label, please assign dom4ha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from dom4ha July 11, 2025 06:07
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from macsko July 11, 2025 06:07
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sunya-ch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Jul 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2025
@sunya-ch sunya-ch mentioned this pull request Jul 11, 2025
Open
4 tasks
@sunya-ch sunya-ch force-pushed the dra-dynamic-provision branch from 235d8fb to 8e4c175 Compare July 15, 2025 06:10
@sunya-ch sunya-ch mentioned this pull request Jul 15, 2025
Merged
@sunya-ch sunya-ch force-pushed the dra-dynamic-provision branch from 8e4c175 to 0d67b6d Compare July 23, 2025 09:01
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2025
@sunya-ch sunya-ch force-pushed the dra-dynamic-provision branch 2 times, most recently from f8449d0 to 732c9b5 Compare July 28, 2025 09:40
johnbelamaric
johnbelamaric reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started reviewing but I think it needs some rework for the most recent changes, so I stopped pretty early. Once all the changes from the implementation phase are incorporated, I will take another look.

keps/sig-scheduling/5075-dra-consumable-capacity/README.md Outdated
When such a policy is specified, the device may be allocated to multiple independent requests, up to its total capacity,
with the platform enforcing the policy and managing allocations on each request accordingly.
In contrast, if no sharing policy is defined, the device is treated as freely shareable and not dedicated to any specific request.
As a result, the resource without a sharing policy imposes no constraints on how new requests are processed.
In contrast, if no request policy is defined, the device is treated as freely shareable and not dedicated to any specific request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer, true, right?

"No request policy" is now equivalent to "a request policy with a default of the full capacity value of the device", such that even for a multi-allocatable device, having no requests and no request policy means it will be exclusively allocated. This is safest as it is most consistent with pre-1.34 behavior, and also just means that the driver author needs to explicitly create a policy if they want something different.

See

keps/sig-scheduling/5075-dra-consumable-capacity/README.md Outdated
@@ -122,11 +129,11 @@ and that resource claim has allocated the device.
With this KEP, independent resource claims (and/or requests within a claim) can allocate shares of the same underlying device.
This enables resource sharing across pods that are completely unrelated, potentially even across different namespaces.

Additionally, if a device supports sharing, its resource (capacity) can be managed through a defined sharing policy.
Additionally, if a device supports sharing, its resource (capacity) can be managed through a defined request policy.
When such a policy is specified, the device may be allocated to multiple independent requests, up to its total capacity,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be re-written now that allow multiple allocations and request policy are decoupled.

@liggitt
Copy link
Member

liggitt commented Jul 28, 2025

+1 to folding in updates to the field names and behavior made during implementation review

@sunya-ch sunya-ch force-pushed the dra-dynamic-provision branch 2 times, most recently from 1d95963 to fae645e Compare July 29, 2025 14:19
@sunya-ch sunya-ch force-pushed the dra-dynamic-provision branch from fae645e to 4daa7a5 Compare July 29, 2025 15:02
@sunya-ch
Copy link
Contributor Author

@liggitt @johnbelamaric I updated the description and API according to the recent API in the implementation.
I also removed the section Device driver migration since we do not need the driver to prevent unintentionally sharing when we set default to full capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunya-ch @k8s-ci-robot @liggitt @johnbelamaric