Skip to content

Move 1967 Support to size memory backed volumes to Beta #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

Move 1967 Support to size memory backed volumes to Beta #2628

merged 1 commit into from
Apr 19, 2021

Conversation

@dims
Copy link
Member

@dims dims commented Apr 15, 2021

related to #1967
related to kubernetes/kubernetes#101048

Signed-off-by: Davanum Srinivas [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
@dims dims mentioned this pull request Apr 15, 2021
Merged
@ehashman
Copy link
Member

ehashman commented Apr 15, 2021

@dims can you ensure to also update the kep.yaml metadata?

@dims dims force-pushed the 1967-size-memory-backed-volumes-to-beta branch from e23c851 to 8b5abd8 Compare April 15, 2021 22:57
@dims
Copy link
Member Author

dims commented Apr 15, 2021

@ehashman Done!

@dims dims force-pushed the 1967-size-memory-backed-volumes-to-beta branch from 8b5abd8 to cbc6ae5 Compare April 15, 2021 23:36
ehashman
ehashman reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0c2aeed into kubernetes:master Apr 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 19, 2021
@ehashman ehashman mentioned this pull request May 14, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehashman ehashman ehashman left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@ehashman ehashman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

3 participants

@dims @k8s-ci-robot @ehashman