Fix bug from 1.0.0 release where clear filter button wasn't re-rendered once filter had been cleared once #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sg00dwin
commented
May 17, 2016
sg00dwin
commented
- because clear filters button is now withing .label-filter-active-filters it was being deleted after first clear
- instead of emptying everything inside label-filter-active-filters it now looks for label with label-filter-active-filter and removes
…ed once filter has been cleared once. - because clear filters button is now withing .label-filter-active-filters it was being deleted after first clear - instead of emptying everything inside label-filter-active-filters it now looks for label with label-filter-active-filter and removes
Contributor
Author
|
@jwforres fix for minor bug from previous release. |
| .text("Clear filters") | ||
| ) | ||
| ).click(function() { | ||
| $(this).hide(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.