Skip to content

memory pools for walkers #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2019
Merged

memory pools for walkers #97

merged 1 commit into from
Aug 17, 2019

Conversation

@lavalamp
Copy link
Contributor

@lavalamp lavalamp commented Aug 16, 2019 

benchmark                       old ns/op     new ns/op     delta
BenchmarkApplyNewObject-12      1363050       1347076       -1.17%
BenchmarkUpdateNewObject-12     1228947       1160335       -5.58%
BenchmarkRepeatedUpdate-12      396604        384544        -3.04%
BenchmarkSetToFields-12         5107          5214          +2.10%
BenchmarkFieldsToSet-12         10170         10118         -0.51%
BenchmarkYAMLToTyped-12         54439         51352         -5.67%

benchmark                       old allocs     new allocs     delta
BenchmarkApplyNewObject-12      4214           4089           -2.97%
BenchmarkUpdateNewObject-12     3661           3568           -2.54%
BenchmarkRepeatedUpdate-12      1179           1111           -5.77%
BenchmarkSetToFields-12         14             14             +0.00%
BenchmarkFieldsToSet-12         82             82             +0.00%
BenchmarkYAMLToTyped-12         90             74             -17.78%

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2019
apelisse
apelisse reviewed Aug 17, 2019
View reviewed changes
typed/typed.go
}
mw := mwPool.Get().(*mergingWalker)
defer func() {
mw.lhs = nil
Copy link
Contributor

@apelisse apelisse Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if you do *mw = mergingWalker{}?

Copy link
Contributor Author

@lavalamp lavalamp Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm deliberately preserving two of the fields...

@apelisse
Copy link
Contributor

apelisse commented Aug 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 78536ba into kubernetes-sigs:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apelisse apelisse apelisse left review comments

@jennybuckley jennybuckley Awaiting requested review from jennybuckley

Assignees

@apelisse apelisse

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lavalamp @apelisse @k8s-ci-robot