Default keys float and int #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
Author
Contributor
Author
lavalamp
reviewed
Nov 13, 2020
merge/default_keys_test.go
Outdated
| ), | ||
| }, | ||
| }, | ||
| "apply_default_type_differs": { |
Contributor
There was a problem hiding this comment.
Perhaps a comment or make the name clear that it's float/int that you're testing?
Contributor
|
lgtm, can you squash? |
apelisse
force-pushed
the
default-keys-float-and-int
branch
from
6f940db to
cdf8e5a
Compare
Contributor
Author
|
OK I think that name is better. |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request shows that even if the default is a float, this will still merge properly if someone applies with an integer for the field.