Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions merge/nested_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ var nestedTypeParser = func() Parser {
- name: mapOfMapsRecursive
type:
namedType: mapOfMapsRecursive
- name: recursiveStruct
type:
namedType: recursiveStruct
- name: recursiveStruct
map:
fields:
- name: name
type:
scalar: string
- name: listOfLists
list:
elementType:
Expand Down Expand Up @@ -500,6 +509,55 @@ func TestUpdateNestedType(t *testing.T) {
),
},
},
"recursiveStruct_remove_nested_dangling": {
Ops: []Operation{
Apply{
Manager: "default",
Object: `
recursiveStruct:
name: a
`,
APIVersion: "v1",
},
Apply{
Manager: "default",
Object: `
`,
APIVersion: "v1",
},
},
// TODO: This is wrong, we're expecting an empty object.
Object: `
recursiveStruct: null
`,
APIVersion: "v1",
Managed: fieldpath.ManagedFields{},
},
"recursiveStruct_remove_dangling": {
Ops: []Operation{
Apply{
Manager: "default",
Object: `
recursiveStruct:
name: a
`,
APIVersion: "v1",
},
Apply{
Manager: "default",
Object: `
recursiveStruct:
`,
APIVersion: "v1",
},
},
// If person applies the empty struct, we should keep it.
Object: `
recursiveStruct:
`,
APIVersion: "v1",
Managed: fieldpath.ManagedFields{},
},
}

for name, test := range tests {
Expand Down