Skip to content

[Trival] replace beta label to GA label for kubernetes #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

[Trival] replace beta label to GA label for kubernetes #160

merged 1 commit into from
Apr 3, 2020

Conversation

@wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Mar 26, 2020

/kind cleanup

Ref: kubernetes/kubernetes#89477

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2020
@wawa0210 wawa0210 changed the title replace beta label to GA label for kubernetes [Trival] replace beta label to GA label for kubernetes Mar 26, 2020
@apelisse
Copy link
Contributor

apelisse commented Mar 26, 2020

Looks like you haven't updated properly? The test is failing.

Thanks!

@wawa0210
Copy link
Contributor Author

wawa0210 commented Mar 28, 2020

Looks like you haven't updated properly? The test is failing.

Thanks!

Done ~
Sorry, the test code was not modified before

@wawa0210
Copy link
Contributor Author

wawa0210 commented Apr 3, 2020 •
edited
Loading

@apelisse Can you take the time to review it again? thx

@apelisse
Copy link
Contributor

apelisse commented Apr 3, 2020

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit e95fcaa into kubernetes-sigs:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@apelisse apelisse

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wawa0210 @apelisse @k8s-ci-robot