Convert numbers like Kubernetes does for json.Marshaler types #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
jpbetz
force-pushed
the
mimic-k8s-json-unmarshal
branch
from
de1be98 to
7a2849f
Compare
Contributor
Author
|
cc @apelisse |
liggitt
reviewed
Feb 7, 2020
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
Would you mind squashing? Thanks |
jpbetz
force-pushed
the
mimic-k8s-json-unmarshal
branch
from
f0c76e8 to
5e70324
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s.io/apimachinery/pkg/runtimetests failures from kubernetes/kubernetes#87908 showed thatjson.Marshalerwas not handled exactly right. We need to handle numbers in collections exactly as Kubernetes does.