Skip to content

Conversation

@sivchari
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2025
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a case where the field is referencing an alias type, with the marker, from another file on disk, that's important to check is working as we don't always reference types from within the same file.

@sivchari sivchari force-pushed the detect-all-markers branch from 75559d5 to c1acd3c Compare July 10, 2025 12:26
@sivchari
Copy link
Member Author

@JoelSpeed

Thanks, done.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2025
Signed-off-by: sivchari <[email protected]>
@sivchari sivchari force-pushed the detect-all-markers branch from c1acd3c to b3326bf Compare July 10, 2025 12:59
@sbueringer
Copy link
Member

@sivchari Sorry, didn't look into the details. Could it be that we can fix this issue (#113) in the optionalfields linter the same way?

@JoelSpeed
Copy link
Contributor

@sivchari Sorry, didn't look into the details. Could it be that we can fix this issue (#113) in the optionalfields linter the same way?

#121 is fixing #113 in the same way, and just needs some edits to the tests to be able to merge

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

I think lets tackle the enum thing separately

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sivchari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit b566fe8 into kubernetes-sigs:main Jul 10, 2025
4 checks passed
@sbueringer
Copy link
Member

I think lets tackle the enum thing separately

Sure absolutely. Also wasn't aware of the other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSATags linter suggests SSA markers on field that already has listType on the type

4 participants