-
Couldn't load subscription status.
- Fork 21
use TypeAwareMarkerCollectionForField to collect markers #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use TypeAwareMarkerCollectionForField to collect markers #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a case where the field is referencing an alias type, with the marker, from another file on disk, that's important to check is working as we don't always reference types from within the same file.
75559d5 to
c1acd3c
Compare
|
Thanks, done. |
Signed-off-by: sivchari <[email protected]>
c1acd3c to
b3326bf
Compare
|
/approve I think lets tackle the enum thing separately |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, sivchari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure absolutely. Also wasn't aware of the other PR |
close #119
/cc @sbueringer @JoelSpeed