Skip to content

Conversation

sbueringer
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbueringer
Once this PR has been reviewed and has the lgtm label, please assign pwittrock for approval by writing /assign @pwittrock in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2022
text: "G304: Potential file inclusion via variable"
- linters:
- revive
text: "package-comments: should have a package comment"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to add package comments everywhere I would suggest to do that in follow-up PRs (I can open an issue for it).

There are a lot of packages with missing package comments

@sbueringer sbueringer changed the title Bump golangci lint to v1.49.0 ✨ Bump golangci lint to v1.49.0 Aug 25, 2022
@sbueringer
Copy link
Member Author

There are 4 open godot findings. In my opinion all false positives.

I see the following options:

  • drop godot
  • add a dot to the last elements of the lists

@alvaroaleman
Copy link
Member

drop godot

I'd be in favor of that

@sbueringer sbueringer closed this Aug 25, 2022
@sbueringer sbueringer force-pushed the pr-bump-golangci-lint branch from b46562b to b9a9086 Compare August 25, 2022 19:50
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-test-master b9a9086 link true /test pull-controller-runtime-test-master
pull-controller-runtime-apidiff-master b9a9086 link false /test pull-controller-runtime-apidiff-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

sbueringer commented Aug 25, 2022

I'd be in favor of that

Done. Not sure what happened. Tried to do a commit -amend with GitHub codespaces and that somehow closed the PR :/

New PR here: #1988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants