-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Simplify cleanupConfigFields in KCP #12776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 Simplify cleanupConfigFields in KCP #12776
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-conformance-ci-latest-main |
/hold |
Signed-off-by: Stefan Büringer [email protected]
f331e2c
to
231500e
Compare
Tests all green, pushed some godoc changes. Won't trigger all e2e tests again just for that |
/hold cancel |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Simplifying KCP logic ahead of the in-place implementation
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #12291