-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 Fix timeout handling in GetAPIServerCertificateExpiry and DialContext #12554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix timeout handling in GetAPIServerCertificateExpiry and DialContext #12554
Conversation
|
@LingyanCao: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
|
Welcome @LingyanCao! |
|
Hi @LingyanCao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@LingyanCao PTAL at the CLA: #12554 (comment) |
|
/ok-to-test |
|
/test pull-cluster-api-e2e-main-gke |
|
/test pull-cluster-api-e2e-main-gke Error is unrelated |
|
Change lgtm. I would merge as soon as the CLA is done |
|
I think this will also fix cases where etcd requests got stuck. @fabriziopandini This might fix some of our resourceVersion not stable flakes with KCP |
fffd455 to
3a23ad4
Compare
3a23ad4 to
b2aca38
Compare
|
Thank you! /test pull-cluster-api-e2e-main-gke |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: b859ee8c190a7f14990733482ecaf7deb243f665
|
What this PR does / why we need it:
This PR adds proper timeout handling to prevent hanging connections when getting API server certificate expiry. The changes include:
context.WithTimeoutCause()inGetAPIServerCertificateExpiry()DialContext()by configuring HTTP client timeout based on context deadlineThese changes prevent indefinite blocking during certificate expiry checks and improve debugging with descriptive timeout errors.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12460
area/provider/control-plane-kubeadm